Editing wiki pages gives HTTP 503 error when a custom hook fails (#258828) 路 Issues 路 GitLab.org / GitLab 路 GitLab

您所在的位置:网站首页 gitlab503 Editing wiki pages gives HTTP 503 error when a custom hook fails (#258828) 路 Issues 路 GitLab.org / GitLab 路 GitLab

Editing wiki pages gives HTTP 503 error when a custom hook fails (#258828) 路 Issues 路 GitLab.org / GitLab 路 GitLab

#Editing wiki pages gives HTTP 503 error when a custom hook fails (#258828) 路 Issues 路 GitLab.org / GitLab 路 GitLab| 来源: 网络整理| 查看: 265

Proposal

Catch errors from custom hooks when editing wiki pages, and improve the error message in the web UI.

For the missing $GIT_DIR we've opened a separate issue at gitaly#3211 (closed).

Previous bug report below:

I've fixed this issue locally

It turned out that all commits were failing due to our server-side custom update hook failing. It would be nice if GitLab would throw a properly informative error rather than just a default GitLab 503 page in this situation.

The update hook was failing because it was no longer being passed a valid $GIT_DIR environment variable.

I "fixed" this by using a regex on $GL_PROJECT_PATH to get the information I was previously looking for from $GIT_DIR

Is it expected that $GIT_DIR is gone from the environment of custom server-side git hooks on GitLab?

Summary

On GitLab 13.4.1 (c90be62bdef) (after multi-step upgrade from 12.10.6 -> 13.0.0 -> 13.4.1)

Attempting to create any new Wiki page on any project gives HTTP/503 error.

Steps to reproduce Go to Wiki on any project Click New Page Fill out an acceptable title and commit message Click Create Page Get a 503 error page from GitLab Additional Notes:

I've run gitlab-ctl restart and also rebooted the whole server, to rule out anything transient post-upgrade as an issue (yet, the issue persists).

Relevant logs and/or screenshots

Results of GitLab environment info Output of sudo gitlab-rake gitlab:env:info: System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.6.6p146 Gem Version: 2.7.10 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 5.0.9 Git Version: 2.28.0 Sidekiq Version:5.2.9 Go Version: unknown GitLab information Version: 13.4.1 Revision: c90be62bdef Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 11.9 URL: https://REDACTED.com HTTP Clone URL: https://REDACTED.com/some-group/some-project.git SSH Clone URL: [email protected]:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 13.7.0 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git Results of GitLab application Check

sudo gitlab-rake gitlab:check SANITIZE=true:

Checking GitLab subtasks ... Checking GitLab Shell ... GitLab Shell: ... GitLab Shell version >= 13.7.0 ? ... OK (13.7.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful Checking GitLab Shell ... Finished Checking Gitaly ... Gitaly: ... default ... OK Checking Gitaly ... Finished Checking Sidekiq ... Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1 Checking Sidekiq ... Finished Checking Incoming Email ... Incoming Email: ... Reply by email is disabled in config/gitlab.yml Checking Incoming Email ... Finished Checking LDAP ... LDAP: ... LDAP is disabled in config/gitlab.yml Checking LDAP ... Finished Checking GitLab App ... Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 3/1 ... yes 3/2 ... yes 3/3 ... yes 3/4 ... yes 3/5 ... yes 3/6 ... yes 3/7 ... yes 3/8 ... yes 3/9 ... yes 3/10 ... yes 3/11 ... yes 3/12 ... yes 3/13 ... yes 3/14 ... yes 3/15 ... yes 3/16 ... yes 3/17 ... yes 3/18 ... yes 3/19 ... yes 3/20 ... yes 3/21 ... yes 3/22 ... yes 3/23 ... yes 3/24 ... yes 3/25 ... yes 3/26 ... yes 3/27 ... yes 3/28 ... yes 3/29 ... yes 3/30 ... yes 3/31 ... yes 3/32 ... yes 3/33 ... yes 3/34 ... yes 3/35 ... yes 3/36 ... yes 3/37 ... yes 3/38 ... yes 3/39 ... yes 6/40 ... yes 3/41 ... yes 3/42 ... yes 2/43 ... yes 3/44 ... yes 3/45 ... yes 3/46 ... yes 3/47 ... yes 3/48 ... yes 3/49 ... yes 3/50 ... yes 3/51 ... yes 3/52 ... yes 3/53 ... yes 3/54 ... yes 3/55 ... yes 3/56 ... yes 3/57 ... yes 3/58 ... yes 3/59 ... yes 3/60 ... yes 3/61 ... yes 3/62 ... yes 3/63 ... yes 3/64 ... yes 3/65 ... yes 3/66 ... yes 3/67 ... yes 6/68 ... yes 3/69 ... yes 3/70 ... yes 3/71 ... yes 3/73 ... yes 3/74 ... yes 3/75 ... yes 3/76 ... yes 3/77 ... yes 3/78 ... yes 3/79 ... yes 3/80 ... yes 3/81 ... yes 3/82 ... yes 3/83 ... yes 3/84 ... yes 3/86 ... yes 3/87 ... yes 3/88 ... yes 20/89 ... yes 20/90 ... yes 3/91 ... yes 3/92 ... yes 2/93 ... yes 3/94 ... yes 3/95 ... yes 2/96 ... yes 3/97 ... yes 3/98 ... yes 3/99 ... yes 3/100 ... yes 3/101 ... yes 3/102 ... yes 3/103 ... yes 3/104 ... yes 6/105 ... yes 3/106 ... yes 3/107 ... yes 3/108 ... yes 3/109 ... yes 3/110 ... yes 3/111 ... yes 3/112 ... yes 24/113 ... yes 3/114 ... yes 3/115 ... yes 3/116 ... yes 3/118 ... yes Redis version >= 4.0.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.6) Git version >= 2.24.0 ? ... yes (2.28.0) Git user has default SSH configuration? ... yes Active users: ... 8 Is authorized keys file accessible? ... yes GitLab configured to store new projects in hashed storage? ... yes All projects are in hashed storage? ... yes Checking GitLab App ... Finished Checking GitLab subtasks ... Finished Possibly Related Issues:

#258647 (closed) #258653 (closed) #206930 (closed) #206933 (closed)

Possible fixes


【本文地址】


今日新闻


推荐新闻


CopyRight 2018-2019 办公设备维修网 版权所有 豫ICP备15022753号-3